-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initiate v4.0.0b3 release #5562
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5562 +/- ##
==========================================
- Coverage 87.26% 86.39% -0.88%
==========================================
Files 81 81
Lines 14244 14243 -1
==========================================
- Hits 12430 12305 -125
- Misses 1814 1938 +124
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should prominently mention the change of interpretation for the size kwarg with multivariate distributions.
And that VI is available again.
@michaelosthege are those not in the release notes, or are you just talking about the text associated with the release on the releases page? |
I think we forgot to add them, VI is still in the list of unported. |
The size kwarg change is already in the release notes. |
RELEASE-NOTES.md
Outdated
@@ -129,6 +129,9 @@ This includes API changes we did not warn about since at least `3.11.0` (2021-01 | |||
- `softmax` and `log_softmax` functions added to `math` module (see [#5279](https://github.com/pymc-devs/pymc/pull/5279)). | |||
- ... | |||
|
|||
### Maintenance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon reconsideration, we probably don't need to mention it at all because it doesn't add new functionality, we just need re move it from the list of not-working things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine to leave it under maintenance. Users likely will not notice something missing from the non-working list but will notice it here, and VI is a pretty big feature to have working again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I pushed a commit that removed this change. I do agree with @twiecki, this changelist should reflect the difference between current and v3, and as such it does not make sense to say something is still working...?
Cholesky distributions also still show up in the not yet working, but they are! |
Actually... several algorithms of VI are not yet working... so maybe we should replace the old notice by something like:
|
Which are not working, and do we plan on making them work or are they gone forever? |
Gone forever, most likely. |
Normalizing flows: pymc/pymc/variational/approximations.py Line 363 in ef5f91b
|
And these: Lines 959 to 962 in e987950
|
And, finally, this one, which seems minor: pymc/pymc/variational/approximations.py Lines 274 to 277 in e987950
|
@@ -129,6 +127,7 @@ This includes API changes we did not warn about since at least `3.11.0` (2021-01 | |||
- `softmax` and `log_softmax` functions added to `math` module (see [#5279](https://github.com/pymc-devs/pymc/pull/5279)). | |||
- ... | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad:
OK, should we leave these with NotImplemented exceptions? If Thomas is correct in anticipating they won't be revived any time soon, perhaps they should be removed from the code base, given that this is a major release. |
I think we should remove it, yes. |
But we can merge this. |
Version bump for v4.0.0b3