Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate v4.0.0b3 release #5562

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Initiate v4.0.0b3 release #5562

merged 5 commits into from
Mar 7, 2022

Conversation

fonnesbeck
Copy link
Member

Version bump for v4.0.0b3

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #5562 (784fe6f) into main (620546b) will decrease coverage by 0.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5562      +/-   ##
==========================================
- Coverage   87.26%   86.39%   -0.88%     
==========================================
  Files          81       81              
  Lines       14244    14243       -1     
==========================================
- Hits        12430    12305     -125     
- Misses       1814     1938     +124     
Impacted Files Coverage Δ
pymc/__init__.py 100.00% <100.00%> (ø)
pymc/sampling_jax.py 0.00% <0.00%> (-98.43%) ⬇️
pymc/parallel_sampling.py 86.71% <0.00%> (-1.00%) ⬇️
pymc/bart/utils.py 85.40% <0.00%> (+2.79%) ⬆️

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should prominently mention the change of interpretation for the size kwarg with multivariate distributions.
And that VI is available again.

@ghost
Copy link

ghost commented Mar 7, 2022

@michaelosthege are those not in the release notes, or are you just talking about the text associated with the release on the releases page?

@twiecki
Copy link
Member

twiecki commented Mar 7, 2022

I think we forgot to add them, VI is still in the list of unported.

@fonnesbeck
Copy link
Member Author

The size kwarg change is already in the release notes.

RELEASE-NOTES.md Outdated
@@ -129,6 +129,9 @@ This includes API changes we did not warn about since at least `3.11.0` (2021-01
- `softmax` and `log_softmax` functions added to `math` module (see [#5279](https://github.com/pymc-devs/pymc/pull/5279)).
- ...

### Maintenance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon reconsideration, we probably don't need to mention it at all because it doesn't add new functionality, we just need re move it from the list of not-working things.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine to leave it under maintenance. Users likely will not notice something missing from the non-working list but will notice it here, and VI is a pretty big feature to have working again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I pushed a commit that removed this change. I do agree with @twiecki, this changelist should reflect the difference between current and v3, and as such it does not make sense to say something is still working...?

@ricardoV94
Copy link
Member

Cholesky distributions also still show up in the not yet working, but they are!

@ricardoV94
Copy link
Member

ricardoV94 commented Mar 7, 2022

Actually... several algorithms of VI are not yet working... so maybe we should replace the old notice by something like:

### Not-yet working features
...
- Some Variational inference algorithms (see PR [#4582](https://github.com/pymc-devs/pymc/pull/4582))
...

@ghost
Copy link

ghost commented Mar 7, 2022

Which are not working, and do we plan on making them work or are they gone forever?

@twiecki
Copy link
Member

twiecki commented Mar 7, 2022

Gone forever, most likely.

@ricardoV94
Copy link
Member

Normalizing flows:

raise NotImplementedInference("Normalizing flows are not yet ported to v4")

@ricardoV94
Copy link
Member

And these:

if self.local:
raise NotImplementedInference("Local inferene aka AEVB is not supported in v4")
if self.batched:
raise NotImplementedInference("Batched inferene is not supported in v4")

@ricardoV94
Copy link
Member

And, finally, this one, which seems minor:

if deterministic:
raise NotImplementedInference(
"Deterministic sampling from a Histogram is broken in v4"
)

@@ -129,6 +127,7 @@ This includes API changes we did not warn about since at least `3.11.0` (2021-01
- `softmax` and `log_softmax` functions added to `math` module (see [#5279](https://github.com/pymc-devs/pymc/pull/5279)).
- ...


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad:

Suggested change

@ghost
Copy link

ghost commented Mar 7, 2022

OK, should we leave these with NotImplemented exceptions? If Thomas is correct in anticipating they won't be revived any time soon, perhaps they should be removed from the code base, given that this is a major release.

@twiecki
Copy link
Member

twiecki commented Mar 7, 2022

I think we should remove it, yes.

@twiecki
Copy link
Member

twiecki commented Mar 7, 2022

But we can merge this.

@fonnesbeck fonnesbeck merged commit afe210a into pymc-devs:main Mar 7, 2022
@fonnesbeck fonnesbeck deleted the release_4.0.0b3 branch March 7, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants