Refactor Rice and Skew Normal distribution #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
ricardoV94
reviewed
May 16, 2021
ricardoV94
reviewed
May 16, 2021
ricardoV94
reviewed
May 16, 2021
ricardoV94
reviewed
May 17, 2021
ricardoV94
reviewed
May 17, 2021
|
I had to add an Great work! |
ricardoV94
force-pushed
the
rice-skewnorm-distribution
branch
from
ca17e38
to
2e15a17
Compare
Thank you for your help and guidance! |
ricardoV94
force-pushed
the
rice-skewnorm-distribution
branch
from
2e15a17
to
3167a58
Compare
|
A rebase was needed :D |
ricardoV94
approved these changes
May 17, 2021
twiecki
pushed a commit
that referenced
this pull request
Jun 5, 2021
* refactor Skewnormal and Rice distribution * add test for rice b and skewnorm tau params * change default parameter to b * Add float32 xfail to `test_rice` Co-authored-by: Farhan Reynaldo <[email protected]> Co-authored-by: Ricardo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes a subset of #4686, specifically Rice and Skew Normal distribution.