Refactor DiscreteWeibull #4615
Merged
Refactor DiscreteWeibull #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Apr 4, 2021
| @@ -817,7 +816,6 @@ def ref_rand(size, lower, upper): | |||
| pm.DiscreteUniform, {"lower": -NatSmall, "upper": NatSmall}, ref_rand=ref_rand | |||
| ) | |||
|
|
|||
| @pytest.mark.xfail(reason="This distribution has not been refactored for v4") | |||
There was a problem hiding this comment.
This one still needs refactoring...
There was a problem hiding this comment.
Will take care of this via #4608
|
Looks correct to me. |
3 tasks
brandonwillard
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring DiscreteWeibull as a test for how to refactor other distributions whose random ops are not implemented in aesara.