Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4 update test framework for distributions random method 2nd attempt #4608

Merged
merged 19 commits into from
Apr 26, 2021
Merged

V4 update test framework for distributions random method 2nd attempt #4608

merged 19 commits into from
Apr 26, 2021

Commits on Apr 23, 2021

  1. Update tests following distributions refactoring 

    The distributions refactoring moves the random variable sampling to
aesara. This relies on numpy and scipy random variables implementation.
So, now the only thing we care about testing is that the parametrization
on the PyMC side is sendible given the one on the Aesara side
(effectively the numpy/scipy one)

More details can be found on issue pymc-devs#4554
pymc-devs#4554
    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    5132c92 View commit details
    Browse the repository at this point in the history

  2. Change tests for more refactored distributions. 

    More details can be found on issue pymc-devs#4554
pymc-devs#4554
    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    45180b1 View commit details
    Browse the repository at this point in the history

  3. Change tests for refactored distributions 

    More details can be found on issue pymc-devs#4554
pymc-devs#4554
    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    7fed128 View commit details
    Browse the repository at this point in the history

  4. Remove tests for random variable samples shape and size 

    Most of the random variable logic has been moved to aesara, as well as
most of the relative tests. More details can be found on issue pymc-devs#4554
    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6cb7a6b View commit details
    Browse the repository at this point in the history

  5. Fix test for half cauchy, renmae mv normal tests and add test for 

    Bernoulli
    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    fe5d7d9 View commit details
    Browse the repository at this point in the history

  6. Add test checking PyMC samples match the aesara ones 

    Also mark test_categorical as expected to fail due to bug on aesara
side. The bug is going to be fixed with 2.0.5 release, so we need to
bump the version for categorical and the test to pass.
    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6b576c4 View commit details
    Browse the repository at this point in the history

  7. Move Aesara to 2.0.5 to include Gumbel distribution

    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b50e92f View commit details
    Browse the repository at this point in the history

  8. Enamble exponential and gamma tests following bug-fix

    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    78ac5ac View commit details
    Browse the repository at this point in the history

  9. Enable categorical test following aesara version bump to 2.0.5 and re… 

    …lative bug-fix
    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b7afa5d View commit details
    Browse the repository at this point in the history

  10. Few small cosmetic changes: 

    - replace list of tuples with dict
- rename 1 method
- move pymc_dist as first argument in function call
- replace list(params) with params.copy()
    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d6c3847 View commit details
    Browse the repository at this point in the history

  11. Remove redundant tests

    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    7b5899c View commit details
    Browse the repository at this point in the history

  12. Further refactoring 

    The refactoring should make it possible testing both the distribution
parametrization and sampled values according to need, as well as any
other future test. More details on PR pymc-devs#4608
    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b1c40ef View commit details
    Browse the repository at this point in the history

  13. Add size tests to new rv testing framework

    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    a817a7e View commit details
    Browse the repository at this point in the history

  14. Add tests for multivariate and for univariate multi-parameters

    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    1c88e55 View commit details
    Browse the repository at this point in the history

  15. remove test already covered in aesara

    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    bf68a3a View commit details
    Browse the repository at this point in the history

  16. fix few names

    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    55b4a0f View commit details
    Browse the repository at this point in the history

  17. Remove "distribution" from test class names

    @ricardoV94 @matteo-pallini
    ricardoV94 authored and matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    706308e View commit details
    Browse the repository at this point in the history

  18. Add discrete Weibull, improve Beta and some minor refactoring

    @matteo-pallini
    matteo-pallini committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    3d28087 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Fix typos in checks naming and add sanity check

    @matteo-pallini
    matteo-pallini committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    9b52e1b View commit details
    Browse the repository at this point in the history