Evaluate only desired branch in log1mexp_numpy #4428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
log1mexp_numpy
in the math module to only apply one of the two operations to the inputs. This avoids the non-important but common RuntimeWarning during NUTS sampling whenlogdiffexp_numpy
is called in thestats
method:The RuntimeWarning occurred because both operations were applied to
x
before selecting the desired (more numerical stable) output withnp.where
.I added a test that fails in Master but passes in this PR.