Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort imports in 10 notebooks #4073

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

MarcoGorelli
Copy link
Contributor

Follow-up from #4072

To get these changes I did the following:

setup.cfg:

[isort]
lines_between_types=1
no_sections=1

.nbqa.ini

[isort]
config = setup.cfg
mutate = 1

and then ran nbqa isort docs/source/notebooks/ --treat-comment-as-code '# %%'

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@MarcoGorelli
Copy link
Contributor Author

MarcoGorelli commented Sep 3, 2020

Just a note on reviewNB - if I open up the diff in there, then for docs/source/notebooks/GP-SparseApprox.ipynb it looks like this:

image

From this diff, it looks like there's a blank line between import pymc3 as pm and import theano. However, if I look at the new notebook here https://github.com/MarcoGorelli/pymc3/blob/next-10-notebooks/docs/source/notebooks/GP-SparseApprox.ipynb then you can see that there is no such blank line:

image

So, the new notebook looks correct to me, it's just the diff on ReviewNB that looks misleading (or maybe it's correct, I'm just not reading it properly 😄 )

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #4073 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4073   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          88       88           
  Lines       13860    13860           
=======================================
  Hits        12263    12263           
  Misses       1597     1597           

Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @MarcoGorelli !

@AlexAndorra AlexAndorra merged commit b51b32f into pymc-devs:master Sep 4, 2020
@MarcoGorelli MarcoGorelli deleted the next-10-notebooks branch September 4, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants