Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get docs for stats and plots to link to ArviZ #3927

Merged
merged 2 commits into from
May 23, 2020

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented May 18, 2020

As discussed in slack, this should make stats and plots api pages to link to ArviZ counterparts, the current look is this one:

image

Uses intersphinx whose configuration has been added to conf.py.

Depending on what your PR does, here are a few things you might want to address in the description:

  • what are the (breaking) changes that this PR makes? None
  • important background, or details about the implementation
  • right before it's ready to merge, mention the PR in the RELEASE-NOTES.md

@twiecki
Copy link
Member

twiecki commented May 19, 2020

This is really cool! I'll refer to @ColCarroll who has done most on docs to confirm that it looks right.

@OriolAbril I think you can already go ahead and add this to the release notes.

@twiecki twiecki requested a review from ColCarroll May 19, 2020 06:29
Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 👏 is 👏 awesome 👏 , thanks a lot @OriolAbril ! I don't see any missing bits where I can help you, but tell me if there are. Waiting for Doc-Master Colin's approval to merge 😉

@OriolAbril
Copy link
Member Author

Things to do would be double checking docs can be generated properly, make sure there are no more linked references to plots or stats functions that have to be updated and review the descriptions and lists of functions to make sure I have not missed any.

@twiecki twiecki merged commit 1522492 into pymc-devs:master May 23, 2020
@twiecki
Copy link
Member

twiecki commented May 23, 2020

Thanks @OriolAbril!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants