Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Moyal distribution #3870

Merged
merged 3 commits into from
Apr 7, 2020
Merged

ENH: Moyal distribution #3870

merged 3 commits into from
Apr 7, 2020

Conversation

fearghuskeeble
Copy link
Contributor

@fearghuskeeble fearghuskeeble commented Apr 6, 2020

I made a class for this distribution when I was working on my thesis. The use may be a little niche but it's at least popular enough to have a scipy class. I added documentation and testing for it so please add it if you would like.

Also included is a typo fix in the Student's T dist. documentation.

For reference the Moyal doc plot would look like this:
moyal_distribution

@twiecki
Copy link
Member

twiecki commented Apr 6, 2020

Seems like travis is unhappy.

@fearghuskeeble
Copy link
Contributor Author

Yes, I'd better check that one on docker because I don't get it locally.

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #3870 into master will decrease coverage by 0.01%.
The diff coverage is 83.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3870      +/-   ##
==========================================
- Coverage   90.72%   90.71%   -0.02%     
==========================================
  Files         135      135              
  Lines       21264    21301      +37     
==========================================
+ Hits        19292    19323      +31     
- Misses       1972     1978       +6     
Impacted Files Coverage Δ
pymc3/distributions/continuous.py 80.01% <76.92%> (-0.09%) ⬇️
pymc3/distributions/__init__.py 100.00% <100.00%> (ø)
pymc3/tests/test_distributions.py 98.16% <100.00%> (+<0.01%) ⬆️
pymc3/tests/test_distributions_random.py 98.52% <100.00%> (+0.01%) ⬆️

@fearghuskeeble
Copy link
Contributor Author

I believe this is ready now

@twiecki twiecki merged commit 3add916 into pymc-devs:master Apr 7, 2020
@twiecki
Copy link
Member

twiecki commented Apr 7, 2020

Thanks @fearghuskeeble!

@fearghuskeeble fearghuskeeble deleted the moyal-distribution branch April 7, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants