Drop nuts init method from pm.sample #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3863 +/- ##
==========================================
- Coverage 90.73% 90.69% -0.04%
==========================================
Files 135 135
Lines 21190 21185 -5
==========================================
- Hits 19227 19214 -13
- Misses 1963 1971 +8
|
twiecki
reviewed
Mar 31, 2020
| @@ -1865,14 +1864,12 @@ def init_nuts( | |||
| * advi: Run ADVI to estimate posterior mean and diagonal mass matrix. | |||
| * advi_map: Initialize ADVI with MAP and use MAP as starting point. | |||
| * map: Use the MAP as starting point. This is discouraged. | |||
| * nuts: Run NUTS and estimate posterior mean and mass matrix from | |||
| the trace. | |||
| * adapt_full: Adapt a dense mass matrix using the sample covariances | |||
| chains: int | |||
| Number of jobs to start. | |||
| n_init: int | |||
There was a problem hiding this comment.
I think n_init is only used for advi now, right? COuld make that clear in the doc string.
|
Thanks! Also release-notes :). |
|
Thanks! |
twiecki
pushed a commit
that referenced
this pull request
Apr 1, 2020
* Added wrapper for gamma sampling in negative binomial distribution. * Fixed typo in posterior sampling warnings. * Drop nuts init method from pm.sample (#3863) * Dropped nuts init method * Dropped nuts init method from tests * Refined doc string and added release note * Added wrapper for gamma sampling in negative binomial distribution. * Fixed typo in posterior sampling warnings. * Added test for negative binomial input shape. * Updating release notes with changes to negative binomial sampling. Co-authored-by: Alexandre ANDORRA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3861, the nuts init method is a left-over in
pm.sampleinit methods and should just be dropped. This PR does it.Thanks in advance for the review, and tell me if any edit is needed 🖖