Add matrix multiplication infix operator #3619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
@
matrix multiplication. Also fixes #3618 once we cut a release 😁Note this is a bit of overkill, in that I just wrap theano's
TensorVariable
, and defer multiplication tott.dot
. I could instead add these methods to each class, but this felt better.I am not sure if I should also update
pm.data.GenTensorVariable
-- I decided not to, since minibatch matrix multiplication seems... tricky.