Update to more accurate way of calculating ancestors #3213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3165. There was a theano function I should have been using the whole time (
theano.gof.graph.ancestors
instead oftheano.gof.graph.inputs
).I suspect accurate listing of parents may help with doing
sample_prior_predictive
(#3210) as well.Both tricky cases mentioned in the issue are fixed, and here's another extra tricky one that has a nice graph. I am also rechecking the radon notebook now.