Fix step method assignment #3203
Conversation
| args = step_kwargs.get(step_class.name, {}) | ||
| used_keys.add(step_class.name) | ||
| step = step_class(vars=vars, **args) | ||
| args = step_kwargs.get(step.name, {}) |
There was a problem hiding this comment.
Where is args actually getting used now?
There was a problem hiding this comment.
Hmm... it doesn't look like it is at all. Perhaps this is related to the Travis errors I'm getting. Will look into this later this week.
There was a problem hiding this comment.
Are you sure that step_class is an object at this point, and not the class? I think there is something suspicious here. If it's not a class, should it be? If it is a class, how could we pass args?
|
Travis failures look real. A good deal of them are just missing |
|
@eigenfoo What's the status of this? |
Closes #3197
This PR does away with the
assigned_varsset, and instead uses theselected_stepsdictionary all the way. It was a fairly clunky implementation to begin with, so this shouldn't be too much of a surprise.What was strange was the line that I deleted:
step = step_class(vars=vars, **args)I think this line was supposed to instantiate
step_class, but the problem is thatstep_classis already an instantiated step method. So as far as I can tell, this method never really worked at all! Not sure how we got here, buttest_sampling.pyis passing locally, so...Asides from that, some readability edits: more explicit variable names, clearer/more docstrings, friendlier error messages.