Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken PyMC's Jupyter Notebook Style link in docs #4485

Closed
matteo-pallini opened this issue Feb 24, 2021 · 3 comments · Fixed by #4486 or sthagen/pymc-devs-pymc#58
Closed

Broken PyMC's Jupyter Notebook Style link in docs #4485

matteo-pallini opened this issue Feb 24, 2021 · 3 comments · Fixed by #4486 or sthagen/pymc-devs-pymc#58

Comments

@matteo-pallini
Copy link
Contributor

I wanted to start contributing on pymc3. While reading the contributing doc I got the impression that the PyMC's Jupyter Notebook Style link is broken.

It seems to be pointing toward a non-existing page https://github.com/pymc-devs/pymc3/wiki/PyMC's-Jupyter-Notebook-Style, and prompts you to create a new one. I guess that it should point toward https://github.com/pymc-devs/pymc3/wiki/PyMC3-Jupyter-Notebook-Style-Guide.

It feels like an easter egg for anyone keen to contribute :-)

@ricardoV94
Copy link
Member

ricardoV94 commented Feb 24, 2021

Thanks for reporting. I opened a PR to fix it (I should have asked first if you wanted to do that in case you are a complete beginner, but hopefully I did not steal it from you!). We have some beginner-friendly issues listed here if you want to pick one: https://github.com/pymc-devs/pymc3/issues?q=is%3Aopen+is%3Aissue+label%3A%22beginner+friendly%22

I recommend you ask first whether the issue you want to work on is still relevant, because we are in a transition period for V4.0, and some things will simply not be needed / used afterwards.

@matteo-pallini
Copy link
Contributor Author

Thanks for picking it up so quickly.

I was considering picking the one below. Mainly because it's among the few ones with no comments, so likely to be unclaimed.
#4425

wdyt? happy to pick another one, if you think it may be a better idea. I am likely to have some free time within the next 10 days, so it would be great to do work that would give me a feeling of the codebase structure. Surely you have more context than me on the codebase and what's needed, so happy to follow your advice

@ricardoV94
Copy link
Member

@DRabbit17 That one is definitely useful and still up to grabs. If you leave a comment there I can assign it to you. Feel free to ask any questions about it over there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants