address some comments

pymc-devs · Oct 25, 2022 · 75a032e · 75a032e
1 parent 65f69d6
commit 75a032e
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 12 deletions.
diff --git a/conda-envs/environment-dev.yml b/conda-envs/environment-dev.yml
@@ -7,7 +7,7 @@ dependencies:
 # Base dependencies
 - aeppl=0.0.38
 - aesara=2.8.7
-- arviz>=0.12.0
+- arviz>=0.13.0
 - blas
 - cachetools>=4.2.1
 - cloudpickle

diff --git a/conda-envs/environment-test.yml b/conda-envs/environment-test.yml
@@ -7,7 +7,7 @@ dependencies:
 # Base dependencies
 - aeppl=0.0.38
 - aesara=2.8.7
-- arviz>=0.12.0
+- arviz>=0.13.0
 - blas
 - cachetools>=4.2.1
 - cloudpickle

diff --git a/conda-envs/windows-environment-dev.yml b/conda-envs/windows-environment-dev.yml
@@ -7,7 +7,7 @@ dependencies:
 # Base dependencies (see install guide for Windows)
 - aeppl=0.0.38
 - aesara=2.8.7
-- arviz>=0.12.0
+- arviz>=0.13.0
 - blas
 - cachetools>=4.2.1
 - cloudpickle

diff --git a/conda-envs/windows-environment-test.yml b/conda-envs/windows-environment-test.yml
@@ -7,7 +7,7 @@ dependencies:
 # Base dependencies (see install guide for Windows)
 - aeppl=0.0.38
 - aesara=2.8.7
-- arviz>=0.12.0
+- arviz>=0.13.0
 - blas
 - cachetools>=4.2.1
 - cloudpickle

diff --git a/pymc/backends/arviz.py b/pymc/backends/arviz.py
@@ -431,9 +431,7 @@ def log_likelihood_to_xarray(self):
     def posterior_predictive_to_xarray(self):
         """Convert posterior_predictive samples to xarray."""
         data = self.posterior_predictive
-        dims = {
-            var_name: self.sample_dims + self.dims.get(var_name, []) for var_name in data.keys()
-        }
+        dims = {var_name: self.sample_dims + self.dims.get(var_name, []) for var_name in data}
         return dict_to_dataset(
             data, library=pymc, coords=self.coords, dims=dims, default_dims=self.sample_dims
         )
@@ -442,9 +440,7 @@ def posterior_predictive_to_xarray(self):
     def predictions_to_xarray(self):
         """Convert predictions (out of sample predictions) to xarray."""
         data = self.predictions
-        dims = {
-            var_name: self.sample_dims + self.dims.get(var_name, []) for var_name in data.keys()
-        }
+        dims = {var_name: self.sample_dims + self.dims.get(var_name, []) for var_name in data}
         return dict_to_dataset(
             data, library=pymc, coords=self.coords, dims=dims, default_dims=self.sample_dims
         )

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -3,7 +3,7 @@
 
 aeppl==0.0.38
 aesara==2.8.7
-arviz>=0.12.0
+arviz>=0.13.0
 cachetools>=4.2.1
 cloudpickle
 fastprogress>=0.2.0

diff --git a/requirements.txt b/requirements.txt
@@ -1,6 +1,6 @@
 aeppl==0.0.38
 aesara==2.8.7
-arviz>=0.12.0
+arviz>=0.13.0
 cachetools>=4.2.1
 cloudpickle
 fastprogress>=0.2.0