Update Parameter Estimation NBs for BCM #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
AlexAndorra
changed the title
|
Updated all the NBs. This is ready for review now ✌️ |
|
I suggest merging this next week -- potential fixes can go on subsequent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is updating NBs for the Parameter Estimation folder of BCM, as discussed in #36
There are two main issues:
The
DataAnalysisNB cannot be run with PyMC's master branch, only with the publicly released 3.8. This is very probably related to this issue.I don't know how to update the code in cell 11 of the original NB in
DataAnalysis.ipynb-- is this PyMC2 code?Binomial NB
DataAnalysis NB
Gaussian NB
Latent-mixtureModels NB
Once the 4 NBs are updated, this will be ready for merge and the other folders will be up for update.
Hope this helps and thanks a lot in advance for reviewing! 🖖