Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve prior comment on GP Birthdays data set. #704

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Sep 19, 2024

The comment in https://www.pymc.io/projects/examples/en/latest/gaussian_processes/GP-Births.html#prior-specifications is confusing as the log transform is tasked on the y variable and has nothing to do with the time dimension (as noted by @AlexAndorra )


📚 Documentation preview 📚: https://pymc-examples--704.org.readthedocs.build/en/704/

@juanitorduz juanitorduz self-assigned this Sep 19, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz added the enhancement New notebook planned to be added to the collection label Sep 19, 2024
Copy link
Member

@fonnesbeck fonnesbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fonnesbeck fonnesbeck merged commit 15cb330 into pymc-devs:main Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New notebook planned to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants