Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stucchio URL #567

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Fix Stucchio URL #567

merged 4 commits into from
Sep 1, 2023

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Aug 23, 2023

The backslashes are appearing in the actual URL

Here's the actual page:

https://www.pymc.io/projects/examples/en/latest/case_studies/bayesian_ab_testing_introduction.html#id79

Note that this old PyMC3 page is much higher on Google:
https://www.pymc.io/projects/docs/en/v3/pymc-examples/examples/case_studies/bayesian_ab_testing.html

Presumably the backslashes were put there for a reason. Maybe something changed with respect to the parsing though? (I'm just saying that I hope fixing this doesn't break something else.)

I'm ignoring the template since I'm modifying the .bib file and not the notebook file.

{Insert Description}

Helpful links


📚 Documentation preview 📚: https://pymc-examples--567.org.readthedocs.build/en/567/

The backslashes are appearing in the actual URL
@OriolAbril
Copy link
Member

It looks like the auto sorting and cleanup of the bibtex file is to blame for this. Can you try updating its version and see if it no longer happens? It wants to undo all the changes you did 😅

Otherwise we'd need to update the pre-commit configuration to use the --no-encode-urls flag. Ref: https://github.com/FlamingTempura/bibtex-tidy#cli

@maresb
Copy link
Contributor Author

maresb commented Sep 1, 2023

Thanks @OriolAbril for tracking this down! (I forgot about pre-commit and didn't notice that failure.) Updating the hook (and the node version) seemed to do the trick, and I fixed another similarly broken URL in the process.

@maresb maresb mentioned this pull request Sep 1, 2023
@OriolAbril OriolAbril merged commit a7bf81a into pymc-devs:main Sep 1, 2023
1 check passed
@OriolAbril
Copy link
Member

Thanks, that was a great catch!

@maresb maresb deleted the fix-stucchio-url branch September 1, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants