Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackbox likelihood #48

Open
OriolAbril opened this issue Mar 24, 2021 · 0 comments
Open

Blackbox likelihood #48

OriolAbril opened this issue Mar 24, 2021 · 0 comments
Labels
extra dependencies Issues that require working with special dependencies tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

file: https://github.com/pymc-devs/pymc-examples/blob/main/examples/case_studies/blackbox_external_likelihood.ipynb

Required changes

The notebook needs to be modified to use ArviZ+InferenceData at the very least, it's hard to know what extra work will be needed as it has not been executed for a while, cython usage is tricky to get right. Note that it uses DensityDist is strange ways, using dicts as observed that contain freeRVs and will need to use density_dist_obs=False as idata_kwargs (ref)

Changes to discuss

I don't think this notebook can be converted to v4 unless it undergoes a significant rewrite. Not sure if we should try to get it working with a custom distribution or with pm.Potential for v4.

⚠️ It requires cython to run.

@OriolAbril OriolAbril added the extra dependencies Issues that require working with special dependencies label Mar 24, 2021
@OriolAbril OriolAbril added the tracker id Issues used as trackers in the notebook update project, do not close! label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extra dependencies Issues that require working with special dependencies tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Status: To delete
Development

No branches or pull requests

1 participant