Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: separate CAs hardening documentation #242

Merged
merged 1 commit into from
Mar 19, 2017
Merged

README: separate CAs hardening documentation #242

merged 1 commit into from
Mar 19, 2017

Conversation

nodiscc
Copy link
Contributor

@nodiscc nodiscc commented Mar 14, 2017

This is based on #239 and adds a single commit/change:

  • split CAs hardening guide to separate file (greatly improves readability of README),
  • Increase CA problem visibility and link to it from 'Further hardening' section
  • deduplicate usage information, link to appropriate sections instead of repeating ourselves

I believe this is a much needed change to get users/contributors to

  • actually read the whole readme
  • actually install user.js without getting rebutted by the apparent complexity of the procedure
  • seriously consider trimming down CA lists as a further hardening step

Preview at:

https://github.com/nodiscc/user.js/blob/readme-separate-cas-doc/README.md#further-hardening
https://github.com/nodiscc/user.js/blob/readme-separate-cas-doc/CAs.md

@nodiscc nodiscc changed the title Readme separate cas doc README: separate CAs hardening documentation Mar 14, 2017
@pyllyukko
Copy link
Owner

I agree that the CAs section might be a bit overkill for the main README. Also looking at the issues/PRs, there doesn't seem to be much attention against it.

It's still an important part of hardening the browser, but it might be better to separate it.

So apparently we should merge either this or #239?

@nodiscc
Copy link
Contributor Author

nodiscc commented Mar 18, 2017

So apparently we should merge either this or #239?

We should wait for #239 to be merged, then merge this (or git cherry-pick 3974a01 but I don't think it can be applied on top of current master that easily, git will probably complain and request manual editing)

…ability of README),

Increase CA problem visibility and link to it from 'Further hardening' section
deduplicate usage information, link to appropriate sections instead of repeating ourselves
@nodiscc
Copy link
Contributor Author

nodiscc commented Mar 19, 2017

Rebased.

@pyllyukko pyllyukko merged commit c7ae29c into pyllyukko:master Mar 19, 2017
@nodiscc nodiscc deleted the readme-separate-cas-doc branch April 26, 2017 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants