-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logjam related disabling of two more DH ciphers #18
Conversation
See "The logjam attack" – https://weakdh.org/
Hm, now that I scroll through the README these two entries are no longer valid with the acceptance of this PR, aren't they?
Should I make a second commit and remove them from the README file? |
Indeed we could mitigate against LogJam with this. I'm afraid many sites will break if we disable these two. Have you tried whether you're able to browse freely with these disabled? I'll switch them off myself and check back whether it causes too much issues. |
And yes, the README should be updated also. Second commit should do the trick. |
You're right. I didn't try it. Will change the README though in case no problems appear and the PR might be acceptable… |
from README file.
Please test with your browser also and tell us if there's any issues? Thanks. |
Will do, but it's not my everyday browser at the moment. :-) |
With (very) quick testing, no sites found... will continue. |
Ok. I'll merge this. If there's some problems, we'll just revert it. It's a shame, as these ciphers have the forward secrecy property. I think we should re-enable them at some point when the dust settles. |
LogJam related disabling of two more DH(E) ciphers
See "The logjam attack" – https://weakdh.org/. The two ciphers are enabled at the moment in user.js but are susceptible to the logjam attack and thus should be disabled as well.