Skip to content

Commit

Permalink
Added Bash syntax test
Browse files Browse the repository at this point in the history
  • Loading branch information
@pyllyukko
pyllyukko committed Dec 3, 2017
1 parent 2f503e1 commit 3228ef0
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@ whatdoesitdo:

# To decrease tests verbosity, comment out unneeded targets
.PHONY: tests
tests: sourceprefs.js checkdeprecated stats acorn
tests: sourceprefs.js checkdeprecated stats acorn bash_syntax

.PHONY: acorn
acorn:
acorn --silent user.js

.PHONY: bash_syntax
bash_syntax:
$(foreach i,$(wildcard *.sh),bash -n $(i);)

# download and sort all known preferences files from Firefox (mozilla-central) source
# specify wanted Firefox version/revision below (eg. "tip", "FIREFOX_AURORA_45_BASE", "9577ddeaafd85554c2a855f385a87472a089d5c0"). See https://hg.mozilla.org/mozilla-central/tags
SOURCEVERSION=tip
Expand Down

3 comments on commit 3228ef0

@nodiscc
Copy link
Contributor

@nodiscc nodiscc commented on 3228ef0 Dec 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. See also shellcheck

@pyllyukko
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShellCheck is a nice tool indeed. We should have that test our scripts also, but first we need to fix all the stuff it complains about :)

@pyllyukko
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d792688

Please sign in to comment.