[Backport maintenance/2.17.x] Fix crash in refactoring checker from unaryop with variable #9076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fixes:
```
File "python3.10/site-packages/pylint/utils/ast_walker.py", line 91, in walk
callback(astroid)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 700, in visit_for
self._check_unnecessary_list_index_lookup(node)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2227, in _check_unnecessary_list_index_lookup
has_start_arg, confidence = self._enumerate_with_start(node)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2352, in _enumerate_with_start
start_val, confidence = self._get_start_value(keyword.value)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2369, in _get_start_value
return node.operand.value, HIGH
AttributeError: 'Name' object has no attribute 'value'
```
Crash is reproducible if you have something like this:
```python
x=5
for _ in enumerate(range, start=-x):
...
```
As a workaround, remove the unary op before `for` loop (i.e. change the
variable used).
Closes #9074
Co-authored-by: Hashem Nasarat <[email protected]>
(cherry picked from commit aa29201)
Pierre-Sassoulas
approved these changes
Sep 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## maintenance/2.17.x #9076 +/- ##
===================================================
Coverage 95.57% 95.57%
===================================================
Files 178 178
Lines 18869 18869
===================================================
Hits 18034 18034
Misses 835 835
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport aa29201 from #9075.