Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tests that had min_pyver=3.7 test setting #8792

Merged

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
🔨 Refactoring

Description

Refs #4683

Unlike py-version, which is still meaningful for lower versions,
min_pyver doesn't have any meaning when it's already the lowest
supported Python interpreter for launching pylint.

Mostly this PR just deletes or shortens .rc files associated with tests; in a few instances, I combined or renamed files to avoid having so many uninformative "py37" suffixes. (But I didn't aim to eradicate them completely; in some cases having the extra file is nice.)

We could do this again for min_pyver=3.8, since 3.8 is minimum on main; see #6306.

Unlike py-version, which is still meaningful for lower versions,
min_pyver doesn't have any meaning when it's already the lowest
supported Python interpreter for launching pylint.
@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Jun 22, 2023
@jacobtylerwalls jacobtylerwalls added this to the 3.0.0a7 milestone Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #8792 (c79ff97) into main (e141906) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8792      +/-   ##
==========================================
- Coverage   95.85%   95.83%   -0.02%     
==========================================
  Files         173      173              
  Lines       18510    18526      +16     
==========================================
+ Hits        17742    17755      +13     
- Misses        768      771       +3     

see 1 file with indirect coverage changes

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 0754b1d into pylint-dev:main Jun 23, 2023
@jacobtylerwalls jacobtylerwalls deleted the clean-up-tests-min-py37 branch June 23, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants