Fix typelias invalid-name false positives for Union variables without assignment.
#8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut assignment. Those variables shouldn't be treated as TypeAlias.
Pierre-Sassoulas
added
False Positive 🦟
Pierre-Sassoulas
approved these changes
Apr 4, 2023
| @@ -3,8 +3,8 @@ | |||
|
|
|||
| # Valid | |||
| TypeAliasShouldBeLikeThis: TypeAlias = int | |||
| _TypeAliasShouldBeLikeThis: Union[str, int] | |||
| _TypeAliasShouldBeLikeThis = Union[str, int] | |||
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 62b9a88 |
|
Looks like the coverage failure is unrelated? |
|
Yeah! Restarted it, should pass in a couple of minutes! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8541 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 174 174
Lines 18353 18353
=======================================
Hits 17602 17602
Misses 751 751
|
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Apr 7, 2023
…ut assignment. (#8541) (#8548) (cherry picked from commit cb255ea) Co-authored-by: Yilei "Dolee" Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those variables shouldn't be treated as TypeAlias.
Type of Changes
Description
Closes #8540