[deprecation] Remove 'do_exit' from the 'Run' constructor #8472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8472 +/- ##
==========================================
+ Coverage 95.76% 95.78% +0.01%
==========================================
Files 174 174
Lines 18358 18348 -10
==========================================
- Hits 17581 17575 -6
+ Misses 777 773 -4
|
This comment has been minimized.
This comment has been minimized.
DanielNoord
reviewed
Mar 21, 2023
| @@ -123,7 +123,6 @@ def __init__( | |||
| args: Sequence[str], | |||
| reporter: BaseReporter | None = None, | |||
| exit: bool = True, # pylint: disable=redefined-builtin | |||
| do_exit: Any = UNUSED_PARAM_SENTINEL, | |||
There was a problem hiding this comment.
We can remove the sentinel as well right?
There was a problem hiding this comment.
Nice catch π
DanielNoord
approved these changes
Mar 21, 2023
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit c4b0afb |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Enacting planned deprecation.