Fix used-before-assignment false positive for walrus operator in dictionary
#8176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
False Positive 🦟
This comment has been minimized.
This comment has been minimized.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8176 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 177 177
Lines 18622 18624 +2
=======================================
+ Hits 17791 17793 +2
Misses 831 831
|
zenlyj
changed the title
used-before-assignment false positiveused-before-assignment false positive for walrus operator in dictionary
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit ed66132 |
Pierre-Sassoulas
approved these changes
Feb 7, 2023
jacobtylerwalls
approved these changes
Feb 10, 2023
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Feb 10, 2023
…ctionary (#8176) (#8254) (cherry picked from commit 32e1545) Co-authored-by: Zen Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix false positive when the walrus operator is used with the ternary operator in dictionary key/value initialization.
Closes #8125