Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid-name for typing_extensions.TypeVar #8089

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jan 20, 2023

Description

typing_extensions recently added it's own version of TypeVar and no longer aliases typing.TypeVar. Adjust name check for that.
https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-440-october-6-2022

@cdce8p cdce8p added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Jan 20, 2023
@cdce8p cdce8p added this to the 2.16.0 milestone Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #8089 (d22c444) into main (b87cf16) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8089      +/-   ##
==========================================
+ Coverage   95.43%   95.44%   +0.01%     
==========================================
  Files         176      176              
  Lines       18545    18545              
==========================================
+ Hits        17698    17700       +2     
+ Misses        847      845       -2     
Impacted Files Coverage Δ
pylint/checkers/base/name_checker/checker.py 99.23% <100.00%> (ø)
pylint/checkers/method_args.py 100.00% <0.00%> (ø)
pylint/checkers/refactoring/refactoring_checker.py 98.33% <0.00%> (+0.20%) ⬆️

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Pierre-Sassoulas Pierre-Sassoulas merged commit 84e1100 into pylint-dev:main Jan 20, 2023
@cdce8p cdce8p deleted the typevar-typing-extensions branch January 20, 2023 14:48
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit d22c444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants