add test and expl for line-too-long useless-supp FP

[clavedeluna]

Type of Changes

	Type
✓	📜 Docs

Description

Closes #3368

[Pierre-Sassoulas]

Some wording, and I think it's better to xfail the expected behavior rather than crystalize the wrong behavior

[DanielNoord]

Some wording, and I think it's better to xfail the expected behavior rather than crystalize the wrong behavior

Isn't the issue here that we can't know for sure that the xfail is because of the original reason? If we break something else the test will still fail. I like documenting the poor behaviour, even though it is not perfect. At least that way we know what is/was expected behaviour rather than "something in this test will fail".

[Pierre-Sassoulas]

Sure, in theory something else could fail, but this is a one line file with only the example, I think we're safe. There's a lot of time where we asked ourselves why something "obviously" wrong was in the functional tests.

[DanielNoord]

Sure, in theory something else could fail, but this is a one line file with only the example, I think we're safe. There's a lot of time where we asked ourselves why something "obviously" wrong was in the functional tests.

Can't we add:

# This test serves mostly to document current behaviour.
# If you manage to make it fail and remove the useless-suppression
# warning please contact Daniel to get your
# celebratory reward (and well done 👍🏻)

[Pierre-Sassoulas]

Sounds great, what's the reward going to be though ? 😄

[DanielNoord]

10 internet points, a beer if they ever meet me in person and an extra speedy review of a PR of choice.
Who wouldn't want to cash in that reward?

[clavedeluna]

Sounds great, what's the reward going to be though ? 😄

Are you agreeing to keeping the original test, so I can revert the latest commit minus doc changes, correct?

[Pierre-Sassoulas]

Sure !

[coveralls]

Pull Request Test Coverage Report for Build 3605491429

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 95.482%

---

Totals
Change from base Build 3587408370:	0.0%
Covered Lines:	17645
Relevant Lines:	18480

---

💛 - Coveralls