Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release process] Add a github actions to backport fix automatically #7776

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✨ New feature
📜 Docs

Description

Based on https://github.com/tibdex/backport which seems awfully conveniant.

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry backport maintenance/2.15.x labels Nov 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.6 milestone Nov 16, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3483486971

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.404%

Totals Coverage Status
Change from base Build 3470628179: 0.0%
Covered Lines: 17354
Relevant Lines: 18190

💛 - Coveralls

github.event.action == 'closed'
|| (
github.event.action == 'labeled'
&& contains(github.event.label.name, 'backport')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&& contains(github.event.label.name, 'backport')
&& contains(github.event.label.name, 'needs backport')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github action's code force us to use this keyword. Also as it's done automatically we don't "need" to do anything 🎉

@Pierre-Sassoulas Pierre-Sassoulas merged commit 6331d95 into main Nov 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the add-backporting-github-action branch November 16, 2022 22:49
@Pierre-Sassoulas
Copy link
Member Author

Pierre-Sassoulas commented Nov 16, 2022

Seems like I still need to tune up the config because of tibdex/backport@v2 is not allowed to be used in PyCQA/pylint. Actions in this workflow must be: within a repository owned by PyCQA, created by GitHub, or matching the following: kanga333/comment-hider@*. I reviewed the code of the action itself and I did not see anything nefarious looking. But it's not an official github action.

@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 32be871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants