Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tox.ini #7358

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Update tox.ini #7358

merged 1 commit into from
Aug 26, 2022

Conversation

mbyrnepr2
Copy link
Member

@mbyrnepr2 mbyrnepr2 commented Aug 25, 2022 •
edited
Loading

Type of Changes

Type
🐛 Bug fix
✨ New feature
✓ 🔨 Refactoring
📜 Docs

Description

  • Install requirements_test.txt into formatting & pylint environments.
    import-error was showing during the pylint run for contributors-txt & colorama in these two environments.
  • Bump minversion to match the version in requirements_test.txt.
  • Bump pre-commit dependency version in the mypy environment to match the version in requirements_test.txt.
************* Module script.create_contributor_list
script/create_contributor_list.py:7:0: E0401: Unable to import 'contributors_txt' (import-error)
************* Module pylint.reporters.text
pylint/reporters/text.py:282:16: E0401: Unable to import 'colorama' (import-error)

Testing

tox -e pylint -r
tox -e formatting -r

@mbyrnepr2 mbyrnepr2 added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Aug 25, 2022
mbyrnepr2
mbyrnepr2 commented Aug 25, 2022
View reviewed changes
tox.ini
envlist = formatting, py37, py38, py39, py310, pypy, benchmark
skip_missing_interpreters = true
requires = pip >=21.3.1
isolated_build = true

[testenv:pylint]
deps =
-r {toxinidir}/requirements_test_min.txt
pre-commit~=2.13
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing since pre-commit is listed in requirements_test.txt.

@coveralls
Copy link

coveralls commented Aug 25, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2929701111

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.306%
Totals Coverage Status
Change from base Build 2926961300: 0.0%
Covered Lines: 16933
Relevant Lines: 17767
💛 - Coveralls

@mbyrnepr2 mbyrnepr2 marked this pull request as ready for review August 25, 2022 15:24
@mbyrnepr2
Update tox.ini
1818543 
- Install `requirements_test.txt` into `formatting` & `pylint` environments.
  `import-error` was showing during the `pylint` run for `contributors-txt` & `colorama` in these two environments.
- Bump `minversion` to match the version in `requirements_test.txt`.
- Bump `pre-commit` dependency version in the `mypy` environment to match the version in `requirements_test.txt`.
@Pierre-Sassoulas Pierre-Sassoulas merged commit bb0df4a into pylint-dev:main Aug 26, 2022
@mbyrnepr2 mbyrnepr2 deleted the update_tox_ini branch August 26, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbyrnepr2 @coveralls @Pierre-Sassoulas