Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'object has no attribute additional_builtins' #6410

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix 'object has no attribute additional_builtins' #6410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ What's New in Pylint 2.13.7?
============================
Release date: TBA

* Fix a crash caused by using the new config from 2.14.0 in 2.13.x code.

Closes #6408


What's New in Pylint 2.13.6?
Expand Down
3 changes: 2 additions & 1 deletion doc/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ cherry-picked on the maintenance branch.
- Bump the version and release by using `tbump X.Y-1.Z --no-push`. (For example:
`tbump 2.3.5 --no-push`)
- Check the result visually with `git show`.
- Push the tag.
- Open a merge request to run the CI tests for this branch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Although tests did seem to pass on the branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 No, the check on non default branches are limited it's only pre-commit that is launched (unless we open a MR).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not noticing/pointing out during review!

- Create and push the tag.
- Release the version on GitHub with the same name as the tag and copy and paste the
appropriate changelog in the description. This triggers the PyPI release.
- Merge the `maintenance/X.Y.x` branch on the main branch. The main branch should have
Expand Down
4 changes: 1 addition & 3 deletions pylint/checkers/variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2069,9 +2069,7 @@ def _is_only_type_assignment(
if not isinstance(defstmt, nodes.AnnAssign) or defstmt.value:
return False

if node.name in self.linter.config.additional_builtins or utils.is_builtin(
node.name
):
if node.name in self.config.additional_builtins or utils.is_builtin(node.name):
return False

defstmt_frame = defstmt.frame(future=True)
Expand Down