Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create _ExtendArgument #6300

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Create _ExtendArgument #6300

merged 1 commit into from
Apr 14, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Currently uncovered but necessary for pyreverse since it has an append option, which in argparse is the same as an extend option.

Added in a separate PR to keep the final pyreverse PR light-weight.

@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 14, 2022
@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Apr 14, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2165658916

  • 9 of 30 (30.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 93.252%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/config/utils.py 1 2 50.0%
pylint/config/arguments_manager.py 1 3 33.33%
pylint/config/argument.py 4 9 44.44%
pylint/config/callback_actions.py 2 7 28.57%
pylint/config/arguments_provider.py 1 9 11.11%
Files with Coverage Reduction New Missed Lines %
pylint/config/arguments_provider.py 2 71.19%
Totals Coverage Status
Change from base Build 2163787619: -0.1%
Covered Lines: 15879
Relevant Lines: 17028
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pylint/config/callback_actions.py
"""Action that adds the value to a pre-existing list.

It is directly copied from the stdlib implementation which is only available
on 3.8+.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could start a TODO list for when we drop 3.7 like #4683 to not forget to cleanup that kind of thing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think whenever we drop support for a version we're likely to do a grep for 3.8 3, 8 and other combinations. But feel free to open one!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6306

@DanielNoord DanielNoord merged commit c5a5e18 into pylint-dev:main Apr 14, 2022
@DanielNoord DanielNoord deleted the argparse-pyreverse-3 branch April 14, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas