Do not use deprecated methods in PyLinter

[DanielNoord]

• Add yourself to CONTRIBUTORS if you are a new contributor.
• Write a good description on what the PR does.

Type of Changes

	Type
✓	🔨 Refactoring

Description

[coveralls]

Pull Request Test Coverage Report for Build 2161969338

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 36 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.1%) to 93.652%

---

Files with Coverage Reduction	New Missed Lines	%
pylint/lint/pylinter.py	2	95.08%
pylint/config/option.py	8	75.53%
pylint/config/arguments_manager.py	26	87.19%

Totals
Change from base Build 2161509428:	-0.1%
Covered Lines:	15889
Relevant Lines:	16966

---

💛 - Coveralls

[Pierre-Sassoulas]

The decrease in coverage makes me think that PyLinter might be used by Plugin lib and that it would be safer to remove that only after the deprecation period.

[DanielNoord]

The decrease in coverage makes me think that PyLinter might be used by Plugin lib and that it would be safer to remove that only after the deprecation period.

See my comment in #5392. I'll take a look at the coverage and see if there are drops that can be fixed, but there is more general problem behind this.

[DanielNoord]

@Pierre-Sassoulas I have fixed the coverage be re-enabling another test (in a hacky way).

The coverage decrease is now due to some inner if statements of some functions not being reached or some validators not being used. This is expected as we decrease the number of calls to optparse functions. Note that we do cover all DeprecationWarnings.

[cdce8p]

This change seems to cause a major regression. At least for Home Assistant the disable config values aren't loaded anymore. HA uses pyproject.toml for the pylint config if that helps.

To reproduce, it's enough to install the basic HA requirements and run

pylint homeassistant/core.py

[DanielNoord]

Investigating!

[DanielNoord]

This change seems to cause a major regression. At least for Home Assistant the disable config values aren't loaded anymore. HA uses pyproject.toml for the pylint config if that helps.

To reproduce, it's enough to install the basic HA requirements and run

pylint homeassistant/core.py

Did you bisect to this commit? I'm trying to replicate but I'm seeing difference in behaviour in pyenv and virtualenv. Seems like configuration discovery might be broken. Don't immediately see why this commit would cause that, but I'll keep looking.

[cdce8p]

Did you bisect to this commit?

Yes.

I'm trying to replicate but I'm seeing difference in behaviour in pyenv and virtualenv. Seems like configuration discovery might be broken. Don't immediately see why this commit would cause that, but I'll keep looking.

I'm using the stdlib venv module. I also did a pip install -e <path>/pylint beforehand.

[DanielNoord]

Error found! PR incoming 😄

[Pierre-Sassoulas]

The fact we merged without detecting the problem is worrying, maybe #5364 would have helped ?

[DanielNoord]

The fact we merged without detecting the problem is worrying, maybe #5364 would have helped ?

We actually had a test for this specific bug but our test was wrong 😅