Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
As noted in this comment the
consider-using-with
message was not triggered if a call likeopen()
was used outside an assignment expression.So while this triggered the message:
this did not:
This is because calls returning context managers were only checked for in the
visit_assign
method.The logic was fixed.
Some new findings in the code base now emerged, which were fixed (or suppressed, for the functional test files).
Type of Changes
Related Issue
None.