Allow protected-access in class methods #4267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>
.Description
This is a pretty basic change to allow accessing protected member inside class methods. It performs three checks:
If all three check out, then we allow access to protected members.
I've added tests for the new behaviour, as well as some (potentially redundant) tests to make sure I wasn't picking up attributes of other classes.
I wasn't 100% sure about how to structure the change log entries, but I've added what I thought was correct. If they need to be amended I can certainly do that.
Type of Changes
Related Issue
Closes #1159