Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check super annotations #2098

Merged
merged 3 commits into from
May 15, 2018

Conversation

benhgreen
Copy link
Contributor

Fixes / new features

@coveralls
Copy link

coveralls commented May 15, 2018

Coverage Status

Coverage increased (+0.008%) to 89.92% when pulling d4dd540 on benhgreen:check-super-annotations into 5bc4529 on PyCQA:master.

@PCManticore PCManticore merged commit 64c4d9c into pylint-dev:master May 15, 2018
@benhgreen benhgreen deleted the check-super-annotations branch May 15, 2018 17:12
@cschramm
Copy link

This expects annotations to have a type with attribute name and breaks simple samples like

from typing import List


class Test:
    def __init__(self, _arg: List[int]) -> None:
        super().__init__()

where it's Subscript and thus does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants