Avoid invalid-name when assigned value is a typing module type #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know it's more of a hack than proper solution (those values should be inferred in astroid), but I feel like we need them as soon as possible for 1.7.0 release. |
Closed
PCManticore
reviewed
Apr 6, 2017
| @@ -139,6 +139,19 @@ def _is_multi_naming_match(match, node_type, confidence): | |||
| match.lastgroup not in EXEMPT_NAME_CATEGORIES | |||
| and (node_type != 'method' or confidence != interfaces.INFERENCE_FAILURE)) | |||
|
|
|||
| def is_typing_type(obj): | |||
There was a problem hiding this comment.
Maybe this should be a brain plugin rather than a specific inference function here? We just need to infer these as classes.
PCManticore
requested changes
Apr 6, 2017
|
@PCManticore feel free to take over if you want to have it merged reasonable quick. I'll be quite busy next week. |
|
Abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1290