-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option to list configuration values #9930 #10035
base: main
Are you sure you want to change the base?
feat: Add option to list configuration values #9930 #10035
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10035 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18935 18935
=======================================
Hits 18141 18141
Misses 794 794
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit c7293f4 |
Is there a chance this could be added to |
pylint-config would need to be very strongly coupled with pylint (use the same configuration discovery and the same parsing for both conf file and args) to be useful. And the goal of creating a new command/tool is to uncouple it from pylint, right ? Or is it to have a less cluttered command line for pylint ? |
It is already doing this.
I think mainly the latter, while also giving a CLI that we can add and modify commands on more quickly. The stability policy on a CLI that you only need once when migrating or installing |
Can someone summarize ? what we want to do |
Daniel is suggesting to add this option in this command: pylint/pylint/config/_pylint_config/main.py Lines 19 to 25 in 6f93e8e
And not in pylint for reasons detailed above. On the other hand discoverability of pylint-config and thus this new feature is not great (I almost forgot it existed myself). What do you think ? |
My thoughts yeah , i think it is better to add option in command but if the discoverability and use cases are less |
Let's add it in pylint-config then ? :) |
ok lets do that and see how it goes |
Type of Changes
Description
working on adding new config-related commands (pylint --config-list and pylint --config-list-show-origin) to help users debug Pylint configuration issues more easily. These commands will display the current configuration values and their origins, similar to how git config list and git config list --show-origin work.
We've added the corresponding options in base_options.py and are defining custom callback actions in callback_actions.py to handle these commands, ensuring that users can retrieve and verify their Pylint configuration setup in a clear and structured way.
Closes #9930