Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign expression / walrus operator is 3.8+ #9820

Closed
nickdrozd opened this issue Jul 20, 2024 · 0 comments · Fixed by #9838 or #9940
Closed

Assign expression / walrus operator is 3.8+ #9820

nickdrozd opened this issue Jul 20, 2024 · 0 comments · Fixed by #9838 or #9940
Assignees
@jacobtylerwalls
Labels
Assignment expression Related to the walrus operator / assignment expression Enhancement ✨ Improvement to a component Needs PR This issue is accepted, sufficiently specified and now needs an implementation py-version python 3.8
Milestone
3.3.0

Comments

@nickdrozd
Copy link
Contributor

Current problem

if (x := f()): ... was introduced in Python 3.8.

Desired solution

If py-version < 3.8, flag it.

Additional context

No response
@nickdrozd nickdrozd added Enhancement ✨ Improvement to a component python 3.8 Assignment expression Related to the walrus operator / assignment expression py-version labels Jul 20, 2024
@jacobtylerwalls jacobtylerwalls added the Needs PR This issue is accepted, sufficiently specified and now needs an implementation label Jul 20, 2024
@jacobtylerwalls jacobtylerwalls self-assigned this Jul 28, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.3.0 milestone Jul 28, 2024
jacobtylerwalls added a commit that referenced this issue Jul 28, 2024
@jacobtylerwalls
Add unsupported version checks for Python 3.8+ syntax
153da4b 
walrus operator #9820
positional-only args #9823
jacobtylerwalls added a commit that referenced this issue Jul 28, 2024
@jacobtylerwalls
Add unsupported version checks for Python 3.8+ syntax
840a95d 
walrus operator #9820
positional-only args #9823
@jacobtylerwalls jacobtylerwalls mentioned this issue Jul 28, 2024
Merged
jacobtylerwalls added a commit that referenced this issue Jul 28, 2024
@jacobtylerwalls
Add unsupported version checks for Python 3.8+ syntax
08f9be9 
walrus operator #9820
positional-only args #9823
jacobtylerwalls added a commit that referenced this issue Jul 28, 2024
@jacobtylerwalls
Add unsupported version checks for Python 3.8+ syntax (#9838)
9f63895 
walrus operator #9820
positional-only args #9823
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
Assignment expression Related to the walrus operator / assignment expression Enhancement ✨ Improvement to a component Needs PR This issue is accepted, sufficiently specified and now needs an implementation py-version python 3.8
Projects
None yet
Milestone
3.3.0
2 participants
@nickdrozd @jacobtylerwalls