[multiple-statements] Exclude the class with Ellipsis from the check

Closes #9398
pylint-dev · Jun 5, 2024 · d985462 · d985462
1 parent a1951c7
commit d985462
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/doc/whatsnew/fragments/9398.false_positive b/doc/whatsnew/fragments/9398.false_positive
@@ -0,0 +1,4 @@
+Classes with only an Ellipsis (``...``) in their body do not trigger 'multiple-statements'
+anymore if they are inlined (in accordance with black's 2024 style).
+
+Closes #9398
diff --git a/pylint/checkers/format.py b/pylint/checkers/format.py
@@ -522,9 +522,8 @@ def visit_default(self, node: nodes.NodeNG) -> None:
 
     def _check_multi_statement_line(self, node: nodes.NodeNG, line: int) -> None:
         """Check for lines containing multiple statements."""
-        # Do not warn about multiple nested context managers
-        # in with statements.
         if isinstance(node, nodes.With):
+            # Do not warn about multiple nested context managers in with statements.
             return
         if (
             isinstance(node.parent, nodes.If)
@@ -539,10 +538,10 @@ def _check_multi_statement_line(self, node: nodes.NodeNG, line: int) -> None:
         ):
             return
 
-        # Functions stubs with ``Ellipsis`` as body are exempted.
+        # Functions stubs and class with ``Ellipsis`` as body are exempted.
         if (
-            isinstance(node.parent, nodes.FunctionDef)
-            and isinstance(node, nodes.Expr)
+            isinstance(node, nodes.Expr)
+            and isinstance(node.parent, (nodes.FunctionDef, nodes.ClassDef))
             and isinstance(node.value, nodes.Const)
             and node.value.value is Ellipsis
         ):

diff --git a/tests/functional/m/multiple_statements.py b/tests/functional/m/multiple_statements.py
@@ -25,7 +25,7 @@
 # (only for classes, not for the examples above)
 class MyException(Exception): print("Golfing sure is nice")  # [multiple-statements]
 class MyError(Exception): pass  # [multiple-statements]
-class DebugTrueDetected(Exception): ...  # [multiple-statements]
+class DebugTrueDetected(Exception): ...
 
 class MyError(Exception): a='a'  # [multiple-statements]
 

diff --git a/tests/functional/m/multiple_statements.txt b/tests/functional/m/multiple_statements.txt
@@ -6,6 +6,5 @@ multiple-statements:15:9:15:13::More than one statement on a single line:HIGH
 multiple-statements:19:9:19:12::More than one statement on a single line:HIGH
 multiple-statements:26:30:26:59:MyException:More than one statement on a single line:HIGH
 multiple-statements:27:26:27:30:MyError:More than one statement on a single line:HIGH
-multiple-statements:28:36:28:39:DebugTrueDetected:More than one statement on a single line:HIGH
 multiple-statements:30:26:30:31:MyError:More than one statement on a single line:HIGH
 multiple-statements:32:26:32:31:MyError:More than one statement on a single line:HIGH