Remove --min_pyver_end_position

pylint-dev · Jul 8, 2024 · 3654b84 · 3654b84
1 parent fb6e2f5
commit 3654b84
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/doc/development_guide/contributor_guide/tests/writing_test.rst b/doc/development_guide/contributor_guide/tests/writing_test.rst
@@ -61,7 +61,6 @@ test runner. The following options are currently supported:
 
 - "min_pyver": Minimal python version required to run the test
 - "max_pyver": Python version from which the test won't be run. If the last supported version is 3.9 this setting should be set to 3.10.
-- "min_pyver_end_position": Minimal python version required to check the end_line and end_column attributes of the message
 - "requires": Packages required to be installed locally to run the test
 - "except_implementations": List of python implementations on which the test should not run
 - "exclude_platforms": List of operating systems on which the test should not run

diff --git a/doc/whatsnew/fragments/9774.other b/doc/whatsnew/fragments/9774.other
@@ -1,4 +1,6 @@
 Remove support for launching pylint with Python 3.8.
 Code that supports Python 3.8 can still be linted with the ``--py-version=3.8`` setting.
 
+``--min_pyver_end_position`` in the functional test runner is no longer relevant and is removed.
+
 Refs #9774
diff --git a/pylint/testutils/functional/test_file.py b/pylint/testutils/functional/test_file.py
@@ -22,7 +22,6 @@ class NoFileError(Exception):
 class TestFileOptions(TypedDict):
     min_pyver: tuple[int, ...]
     max_pyver: tuple[int, ...]
-    min_pyver_end_position: tuple[int, ...]
     requires: list[str]
     except_implementations: list[str]
     exclude_platforms: list[str]
@@ -33,7 +32,6 @@ class TestFileOptions(TypedDict):
 POSSIBLE_TEST_OPTIONS = {
     "min_pyver",
     "max_pyver",
-    "min_pyver_end_position",
     "requires",
     "except_implementations",
     "exclude_platforms",
@@ -47,7 +45,6 @@ class FunctionalTestFile:
     _CONVERTERS: dict[str, Callable[[str], tuple[int, ...] | list[str]]] = {
         "min_pyver": parse_python_version,
         "max_pyver": parse_python_version,
-        "min_pyver_end_position": parse_python_version,
         "requires": lambda s: [i.strip() for i in s.split(",")],
         "except_implementations": lambda s: [i.strip() for i in s.split(",")],
         "exclude_platforms": lambda s: [i.strip() for i in s.split(",")],
@@ -61,7 +58,6 @@ def __init__(self, directory: str, filename: str) -> None:
         self.options: TestFileOptions = {
             "min_pyver": (2, 5),
             "max_pyver": (4, 0),
-            "min_pyver_end_position": (3, 8),
             "requires": [],
             "except_implementations": [],
             "exclude_platforms": [],

diff --git a/pylint/testutils/lint_module_test.py b/pylint/testutils/lint_module_test.py
@@ -79,9 +79,6 @@ def __init__(
         self._linter._arg_parser.add_argument(
             "--max_pyver", type=parse_python_version, default=(4, 0)
         )
-        self._linter._arg_parser.add_argument(
-            "--min_pyver_end_position", type=parse_python_version, default=(3, 8)
-        )
         self._linter._arg_parser.add_argument(
             "--requires", type=lambda s: [i.strip() for i in s.split(",")], default=[]
         )