Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut cache_generator #654

Closed
wants to merge 1 commit into from
Closed

Conversation

nickdrozd
Copy link
Contributor

Is cache_generator doing anything? Cutting it doesn't break anything
as far as I can tell, and it Pylint even seems to go a little faster
without it.

Is cache_generator doing anything? Cutting it doesn't break anything
as far as I can tell, and it Pylint even seems to go a little faster
without it.
@nickdrozd
Copy link
Contributor Author

Someone else should try this on a large repo and see what happens.

@PCManticore
Copy link
Contributor

It's possible cache_generator is not having the performance impact we expected it to have, but having some tests with pylint on top of libraries like numpy or pandas could prove that.

@kodonnell
Copy link

As per here:

Allow partial caching. Currently an inference value is only cached if the inference is completely exhausted. Since there are many instances of only retrieving the first value of the inference, caching is ignored because there is no partial caching.

So - probably want to fix it (easy?) as opposed to getting rid of it - and hopefully that'll actually improve performance.

@PCManticore
Copy link
Contributor

Yeah, that makes sense, it is possible that addressing some of its flaws could result in a performance improvement albeit minor.

@PCManticore PCManticore closed this Jun 2, 2019
@nickdrozd nickdrozd deleted the cache-generator branch October 7, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants