Don't clone the underlying path when cloning contexts for performance reasons #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not copy the inference path all the time, as that causes serious performance regressions on large libraries and on large inference paths. Unfortunately it's not obvious in which code paths we have to branch out and in which we should not. This commit introduces a flag, `branch_path`, which is used in inference to specify the points where a branching out is needed by creating a copy of the inference path of an inference context.
PCManticore
force-pushed
the
revert-perf-affecting-changes
branch
from
7de1c20
to
096395d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR for finding what caused the performance slowdown of pylint-dev/pylint#2198