Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify on non-Module roots #2536

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Clarify on non-Module roots #2536

merged 3 commits into from
Oct 7, 2024

Commits on Oct 7, 2024

  1. remove last instances of Unknown parents (and None parents in tests) 

    It's a part of the campaign to get rid of non-module roots
    @temyurchenko
    temyurchenko committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    846376d View commit details
    Browse the repository at this point in the history

  2. assert that the root() is always a Module 

    The nodes are often created in an ad-hoc way, and their parent is not
   always set. We can't control for that invariant fully in the
   constructor, since the parent is sometimes set outside of the
   constructor. The previous commits did their best to clean up such
   situations, but let's add an assert just in case.
    @temyurchenko
    temyurchenko committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7a702eb View commit details
    Browse the repository at this point in the history

  3. rename the «adhoc module» to «synthetic root»

    @temyurchenko
    temyurchenko committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5e77e13 View commit details
    Browse the repository at this point in the history