Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress UserWarning when finding module specs #2121

Merged
merged 3 commits into from
Apr 16, 2023

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Apr 16, 2023

Last one for the week, promise :-)

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Suppress the UserWarning emitted when linting this code:

import setuptools
import pip

Closes pylint-dev/pylint#7906

Found when linting this code:
import setuptools
import pip
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #2121 (6094e8b) into main (ee2d4bd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
+ Coverage   92.80%   92.82%   +0.01%     
==========================================
  Files          94       94              
  Lines       10958    10962       +4     
==========================================
+ Hits        10170    10175       +5     
+ Misses        788      787       -1     
Flag Coverage Ξ”
linux 92.53% <100.00%> (+0.01%) ⬆️
pypy 88.14% <100.00%> (+0.04%) ⬆️
windows 92.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
astroid/interpreter/_import/spec.py 97.44% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘Œ

@Pierre-Sassoulas Pierre-Sassoulas merged commit 6723e63 into pylint-dev:main Apr 16, 2023
github-actions bot pushed a commit that referenced this pull request Apr 16, 2023
Found when linting this code:
```
import setuptools
import pip
```

(cherry picked from commit 6723e63)
Pierre-Sassoulas pushed a commit that referenced this pull request Apr 16, 2023
Found when linting this code:
```
import setuptools
import pip
```

(cherry picked from commit 6723e63)

Co-authored-by: Jacob Walls <[email protected]>
@jacobtylerwalls jacobtylerwalls deleted the pip-warning branch April 16, 2023 20:25
@Pierre-Sassoulas Pierre-Sassoulas added backported Assigned once the backport is done and removed backport maintenance/2.15.x labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Assigned once the backport is done Bug πŸͺ³
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warnings.UserWarning not suppressed when importing modules to parse their syntax trees.
2 participants