Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More conservative interpretation of PathFinder.find_spec() failures #1581

Merged
merged 2 commits into from
May 31, 2022

Conversation

jacobtylerwalls
Copy link
Member

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

First of all, there was just an issue in pytest to work around. See pytest-dev/apipkg#13.

Second, I think it was wrong to assume that any ValueError from importlib signified a namespace package. I was originally just trying to pass the astroid test case that promises support for the very old pkg_resources namespace package protocol, i.e. .pth files. When .pth files are executed, they're in sys.modules, so here I just check for that.

Type of Changes

Type
🐛 Bug fix

Related Issue

Follow up to #1536. Resolves issue in pandas revealed by pylint primer.

@coveralls
Copy link

coveralls commented May 31, 2022

Pull Request Test Coverage Report for Build 2416557299

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 91.933%

Totals Coverage Status
Change from base Build 2413685707: 0.006%
Covered Lines: 9254
Relevant Lines: 10066

💛 - Coveralls

@DanielNoord
Copy link
Collaborator

Should we add some tests for this/

@jacobtylerwalls jacobtylerwalls merged commit 8bd9ff4 into pylint-dev:main May 31, 2022
@jacobtylerwalls jacobtylerwalls deleted the better-pth-detection branch May 31, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pylint-tested PRs that don't cause major regressions with pylint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants