More conservative interpretation of PathFinder.find_spec()
failures
#1581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
First of all, there was just an issue in
pytest
to work around. See pytest-dev/apipkg#13.Second, I think it was wrong to assume that any
ValueError
fromimportlib
signified a namespace package. I was originally just trying to pass the astroid test case that promises support for the very oldpkg_resources
namespace package protocol, i.e..pth
files. When.pth
files are executed, they're insys.modules
, so here I just check for that.Type of Changes
Related Issue
Follow up to #1536. Resolves issue in
pandas
revealed by pylint primer.