-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #1575 and catch further KeyError
s
#1576
Conversation
Pull Request Test Coverage Report for Build 2411252360
💛 - Coveralls |
My hope is that the failure in |
Still a failure. But no sign of anything getting worse. I'll try to reproduce it -- maybe it was caused earlier than any of this. |
I saw python/mypy#11143 recently, mypy seems to have a nice system for import / sys.path issues, we could take some inspiration. |
@Pierre-Sassoulas @DanielNoord This appears to have fixed the OP's issue in pylint-dev/pylint#1361 ❗ 🤯 💥 |
I mean, using Well done @jacobtylerwalls! Let's hope this resolves some more issues with namespace packages. |
Steps
Description
Chaotic, I know, but I found additional
KeyError
s, and when I compared the behavior after importing the packages, it suggested the original approach before #1575 was right. Any and all feedback welcome, I still find my footing uncertain.For the tree a > b > c.py:
Type of Changes
Related Issue
#1575