-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix col_offset
attribute for nodes involving with
on PyPy
#1520
Conversation
Pull Request Test Coverage Report for Build 2208563637
💛 - Coveralls |
@Pierre-Sassoulas What do we think of postponing running There seems to be an issue with I'd propose:
|
Yes, let's drop python 3.6 first ! |
@DanielNoord I just pushed some small changes which did fix PyPy on Python 3.6. I believe the issue was with function decorators and resulting different lineno. Turns out though, we can just reuse |
Thanks for taking the time to investigate this a little further. I gave up once I saw it was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are fixed now, guess we don't need to wait before merging this one. Will leave the decision up to you @DanielNoord.
…#1520) Co-authored-by: Marc Mueller <[email protected]>
…#1520) Co-authored-by: Marc Mueller <[email protected]>
Steps
Description
For some reason these are incorrect on
PyPy
...Type of Changes
Related Issue