Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix col_offset attribute for nodes involving with on PyPy #1520

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

For some reason these are incorrect on PyPy...

Type of Changes

Type
🐛 Bug fix

Related Issue

@coveralls
Copy link

coveralls commented Apr 20, 2022

Pull Request Test Coverage Report for Build 2208563637

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 91.473%

Changes Missing Coverage Covered Lines Changed/Added Lines %
astroid/rebuilder.py 6 9 66.67%
Totals Coverage Status
Change from base Build 2207055108: -0.02%
Covered Lines: 9097
Relevant Lines: 9945

💛 - Coveralls

@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas What do we think of postponing running PyPy 3.8 on pylint CI until after 2.14?

There seems to be an issue with PyPy 3.6 and I don't really want to spend another couple of hours investigating it since we drop support in a couple of weeks.

I'd propose:

  1. Release pylint 2.14
  2. Drop support for 3.6 in astroid
  3. Release astroid 2.x with this fix in it.
  4. Merge Run PyPy 3.8 and 3.9 in CI pylint#6406

@Pierre-Sassoulas
Copy link
Member

Yes, let's drop python 3.6 first !

@DanielNoord DanielNoord modified the milestones: 2.11.4, 2.12.0 Apr 22, 2022
@cdce8p cdce8p modified the milestones: 2.12.0, 2.11.4 Apr 22, 2022
@cdce8p
Copy link
Member

cdce8p commented Apr 22, 2022

@DanielNoord I just pushed some small changes which did fix PyPy on Python 3.6. I believe the issue was with function decorators and resulting different lineno. Turns out though, we can just reuse position.col_offset for that.

@DanielNoord
Copy link
Collaborator Author

@DanielNoord I just pushed some small changes which did fix PyPy on Python 3.6. I believe the issue was with function decorators and resulting different lineno. Turns out though, we can just reuse position.col_offset for that.

Thanks for taking the time to investigate this a little further. I gave up once I saw it was 3.6, but this is indeed quite easy and elegant.

Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are fixed now, guess we don't need to wait before merging this one. Will leave the decision up to you @DanielNoord.

@DanielNoord DanielNoord merged commit d44083e into pylint-dev:main Apr 22, 2022
@DanielNoord DanielNoord deleted the pypy-async branch April 22, 2022 15:25
Pierre-Sassoulas pushed a commit that referenced this pull request May 2, 2022
Pierre-Sassoulas pushed a commit that referenced this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants