Add filter for abc.collections in dataclass inference #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
approved these changes
Aug 22, 2021
|
No problem, I'm trying to keep an eye out for dataclass type-related issues 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Okay, so the filter introduced in #1130 correctly excluded imports from
typing, but didn't exclude imports fromcollections.abc. Fixed that by adding the module's name to the existing filter. Note: the module defines its__name__as'collections.abc', but the.namenode attribute is generated from the file name,_collections_abc.py.Type of Changes
Related Issue
Closes pylint-dev/pylint#4895