-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building multiple ort-sys with download-binaries
may fail
#322
Comments
3 tasks
decahedron1
added a commit
that referenced
this issue
Nov 23, 2024
qryxip
pushed a commit
to qryxip/ort
that referenced
this issue
Nov 24, 2024
(cherry picked from commit eb51646) Conflicts: ort-sys/build.rs ort-sys/src/internal/mod.rs src/session/builder/impl_commit.rs
qryxip
added a commit
to VOICEVOX/ort
that referenced
this issue
Nov 25, 2024
Fixes the problem where building multiple ort-sys `download-binaries` fail. Cherry picked from eb51646, eb51646, and pykeio#323. Refs: VOICEVOX/voicevox_core#859, pykeio#322 Refs: eb51646 Refs: effd7a7, pykeio#323 Co-authored-by: Carson M. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When you use ort with
download-binaries
both independencies
and inbuild-dependencies
, in the following code, in-progresslib_dir
may be used.ort/ort-sys/build.rs
Lines 462 to 467 in 548bfed
Perhaps
fetch-models
has the same problem.Solutions I come up with
Lock
lib_dir
with fs4 or somethingFYI, Cargo calls
flock(2)
andFileLockExt
directly.Extract the TGZ in a temporary directory and move it to
lib_dir
Detect if
lib_dir
is in-progress and just panic with a human readable messageReproduction
Not yet, but I feel it happens for EPs.
The text was updated successfully, but these errors were encountered: